Skip to content

Release 🚀 #139

Merged
jajeffries merged 2 commits intoreleasefrom
develop
Jun 26, 2025
Merged

Release 🚀 #139
jajeffries merged 2 commits intoreleasefrom
develop

Conversation

@jajeffries
Copy link
Contributor

@jajeffries jajeffries commented Jun 25, 2025

This pull request introduces support for a "dry-run" mode in the deviceDiscoveryBackend and workerBackend components, along with corresponding configuration updates, tests, and documentation changes. The dry-run mode allows operations to be simulated without making actual changes, providing a safer way to test configurations and workflows.

Backend Updates for Dry-Run Mode:

  • deviceDiscoveryBackend Enhancements:

    • Added diodeDryRun and diodeDryRunOutputDir fields to support dry-run mode.
    • Updated the Configure method to parse dry-run-related settings from the configuration.
    • Modified the Start method to conditionally include dry-run arguments in the command options.
  • workerBackend Enhancements:

    • Added diodeDryRun and diodeDryRunOutputDir fields to support dry-run mode.
    • Updated the Configure method to parse dry-run-related settings from the configuration.
    • Modified the Start method to conditionally include dry-run arguments in the command options.
    • Fixed a bug in the Start method where the wrong channel (stdout) was being read instead of stderr.

Configuration and Testing:

  • Configuration Updates:

    • Extended the BackendCommons struct to include DryRun and DryRunOutputDir fields for dry-run mode.
  • New Tests:

    • Added TestDeviceDiscoveryBackendDryRun to validate dry-run functionality for deviceDiscoveryBackend.
    • Added TestWorkerBackendDryRun to validate dry-run functionality for workerBackend.

Documentation and Dockerfile:

  • Documentation:

    • Updated docs/config_samples.md to clarify the usage of lookup_extensions_dir and fix minor grammatical issues. [1] [2]
  • Dockerfile:

    • Removed redundant directory creation and copying commands related to SNMP discovery.

@github-actions
Copy link

github-actions bot commented Jun 25, 2025

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 0.39s github.com/netboxlabs/orb-agent/agent 0.0% 0 0 0
🟢 PASS 0.39s github.com/netboxlabs/orb-agent/agent/backend 0.0% 0 0 0
🟢 PASS 5.03s github.com/netboxlabs/orb-agent/agent/backend/devicediscovery 76.0% 3 0 0
🟢 PASS 0.01s github.com/netboxlabs/orb-agent/agent/backend/mocks 0.0% 0 0 0
🟢 PASS 4.04s github.com/netboxlabs/orb-agent/agent/backend/networkdiscovery 76.3% 2 0 0
🟢 PASS 4.02s github.com/netboxlabs/orb-agent/agent/backend/otel 76.4% 2 0 0
🟢 PASS 3.02s github.com/netboxlabs/orb-agent/agent/backend/pktvisor 65.6% 2 0 0
🟢 PASS 4.02s github.com/netboxlabs/orb-agent/agent/backend/snmpdiscovery 77.7% 2 0 0
🟢 PASS 5.04s github.com/netboxlabs/orb-agent/agent/backend/worker 76.0% 3 0 0
🟢 PASS 1.01s github.com/netboxlabs/orb-agent/agent/config 100.0% 6 0 0
🟢 PASS 1.06s github.com/netboxlabs/orb-agent/agent/configmgr 49.2% 9 0 0
🟢 PASS 1.01s github.com/netboxlabs/orb-agent/agent/policies 100.0% 15 0 0
🟢 PASS 1.03s github.com/netboxlabs/orb-agent/agent/policymgr 70.3% 10 0 0
🟢 PASS 2.51s github.com/netboxlabs/orb-agent/agent/secretsmgr 45.7% 45 0 0
🟢 PASS 1.01s github.com/netboxlabs/orb-agent/agent/version 100.0% 1 0 0

Total coverage: 57.8%

@jajeffries jajeffries requested a review from leoparente June 25, 2025 15:42
@jajeffries jajeffries marked this pull request as ready for review June 25, 2025 15:43
@jajeffries jajeffries merged commit 4259667 into release Jun 26, 2025
7 checks passed
@github-actions
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants