Merged
Conversation
|
Go test coverage
Total coverage: 57.8% |
leoparente
approved these changes
Jun 25, 2025
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for a "dry-run" mode in the
deviceDiscoveryBackendandworkerBackendcomponents, along with corresponding configuration updates, tests, and documentation changes. The dry-run mode allows operations to be simulated without making actual changes, providing a safer way to test configurations and workflows.Backend Updates for Dry-Run Mode:
deviceDiscoveryBackendEnhancements:diodeDryRunanddiodeDryRunOutputDirfields to support dry-run mode.Configuremethod to parse dry-run-related settings from the configuration.Startmethod to conditionally include dry-run arguments in the command options.workerBackendEnhancements:diodeDryRunanddiodeDryRunOutputDirfields to support dry-run mode.Configuremethod to parse dry-run-related settings from the configuration.Startmethod to conditionally include dry-run arguments in the command options.Startmethod where the wrong channel (stdout) was being read instead ofstderr.Configuration and Testing:
Configuration Updates:
BackendCommonsstruct to includeDryRunandDryRunOutputDirfields for dry-run mode.New Tests:
TestDeviceDiscoveryBackendDryRunto validate dry-run functionality fordeviceDiscoveryBackend.TestWorkerBackendDryRunto validate dry-run functionality forworkerBackend.Documentation and Dockerfile:
Documentation:
docs/config_samples.mdto clarify the usage oflookup_extensions_dirand fix minor grammatical issues. [1] [2]Dockerfile: