Merged
Conversation
Semantic Release Dry Run Results 🔍ℹ️ No new release would be published Commit Messages: No semantic changes detected that would trigger a release. |
|
Go test coverage
Total coverage: 58.0% |
Contributor
Author
@jajeffries this does not seem right |
mfiedorowicz
approved these changes
Jul 28, 2025
Semantic Release Dry Run Results 🔍ℹ️ No new release would be published Commit Messages: No semantic changes detected that would trigger a release. |
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and refactors across multiple components of the codebase. The key changes include the addition of a semantic release workflow, support for a "dry-run" mode in discovery backends, and improvements to the Vault test infrastructure. These changes aim to improve CI/CD capabilities, enhance configurability, and modernize testing.
CI/CD Enhancements:
.github/workflows/pr-semantic-release.yaml) to perform a semantic release dry-run for pull requests targeting thereleasebranch. This workflow analyzes commit messages, simulates a release, and comments the results on the pull request.Discovery Backend Improvements:
dry_runanddry_run_output_dirconfiguration options for bothnetworkDiscoveryBackendandsnmpDiscoveryBackend. These options allow the backends to operate in a simulation mode, bypassing live API interactions. (agent/backend/networkdiscovery/network_discovery.go: [1] [2] [3];agent/backend/snmpdiscovery/snmp_discovery.go: [4] [5] [6]networkDiscoveryBackendandsnmpDiscoveryBackendto validate behavior and ensure proper argument handling. (network_discovery_test.go: [1];snmp_discovery_test.go: [2]Documentation Updates:
README.mdto include the newdry_runanddry_run_output_dirconfiguration options under thecommonsubsection of thebackendsconfiguration.Vault Test Refactor:
testclusterimplementation for improved reliability and consistency in testing. This refactor impacts multiple test cases and introduces a newcreateTestVaulthelper function. (vault_test.go: [1] [2] [3] [4];vault_auth_test.go: [5]