-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add chat provisioning #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds chat/messaging provisioning capabilities to the CTI application by integrating with a Matrix-based chat API. The implementation enables Acrobits softphone clients to send and receive messages through the provisioned XML configuration.
Key Changes:
- Added two new helper functions (
postJsonRequestandmakeCTIRequest) to handle CTI API authentication and requests - Integrated chat configuration into the account provisioning XML when the CTI API returns Matrix chat endpoints
- Chat functionality gracefully degrades when not available, logging a debug message
Comments suppressed due to low confidence (2)
app/index.php:255
- SSL certificate verification is disabled with
CURLOPT_SSL_VERIFYPEERset to false. This makes the application vulnerable to man-in-the-middle attacks. SSL verification should be enabled in production environments to ensure secure communication with the CTI API endpoints.
curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);
app/index.php:193
- SSL certificate verification is disabled with
CURLOPT_SSL_VERIFYPEERset to false. This makes the application vulnerable to man-in-the-middle attacks. SSL verification should be enabled in production environments to ensure secure communication with the API endpoints.
curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The function is deprecated.
Allow to put the service in production even if destination server does still not have the chat endpoint
Add AccountXML config for chat:
Linked work
PRs for chat implementation:
New repository for chat implementation:
Issues: