Skip to content

Conversation

@edospadoni
Copy link
Member

@edospadoni edospadoni commented Sep 10, 2025

@edospadoni edospadoni requested a review from Amygos September 10, 2025 14:42
@edospadoni edospadoni marked this pull request as ready for review September 10, 2025 14:42
@Amygos Amygos requested a review from Copilot September 11, 2025 08:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements OAuth (specifically OIDC) login functionality for the sun-ui application. It adds comprehensive support for authenticating users through an external OIDC provider (like Logto or My Nethesis) as an alternative to traditional username/password authentication.

Key Changes:

  • Added OIDC client-side integration with login button and callback handling
  • Implemented secure backend OIDC authentication flow with state validation and token exchange
  • Added comprehensive error handling and internationalization support

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
sun/sun-ui/src/styles/main.css Added CSS styles for OIDC login UI components including buttons, separators, and responsive design
sun/sun-ui/src/services/login.js Added OIDC login methods for initiating authentication and fetching provider configuration
sun/sun-ui/src/routes/router.js Added login callback route handler for processing OIDC authentication responses
sun/sun-ui/src/i18n/locale-it.json Added Italian translations for OIDC login messages and error states
sun/sun-ui/src/i18n/locale-en.json Added English translations for OIDC login messages and error states
sun/sun-ui/src/App.vue Updated login UI to include OIDC authentication option and error handling
sun/sun-api/methods/authentication.go Implemented complete OIDC authentication backend with secure state management and token exchange
sun/sun-api/main.go Added OIDC API endpoints to the router configuration
sun/sun-api/configuration/configuration.go Added OIDC configuration structure for provider settings
go.mod Added required OIDC and OAuth2 dependencies
deploy/ansible/roles/sun/templates/sun-api-conf.j2 Added OIDC configuration template for deployment

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Amygos Amygos requested a review from Copilot September 11, 2025 13:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 5 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

edospadoni and others added 2 commits September 11, 2025 16:17
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Amygos Amygos requested a review from Copilot September 18, 2025 08:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants