-
Notifications
You must be signed in to change notification settings - Fork 12
feat: added OAuth login #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
9d0357e to
da04a22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements OAuth (specifically OIDC) login functionality for the sun-ui application. It adds comprehensive support for authenticating users through an external OIDC provider (like Logto or My Nethesis) as an alternative to traditional username/password authentication.
Key Changes:
- Added OIDC client-side integration with login button and callback handling
- Implemented secure backend OIDC authentication flow with state validation and token exchange
- Added comprehensive error handling and internationalization support
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| sun/sun-ui/src/styles/main.css | Added CSS styles for OIDC login UI components including buttons, separators, and responsive design |
| sun/sun-ui/src/services/login.js | Added OIDC login methods for initiating authentication and fetching provider configuration |
| sun/sun-ui/src/routes/router.js | Added login callback route handler for processing OIDC authentication responses |
| sun/sun-ui/src/i18n/locale-it.json | Added Italian translations for OIDC login messages and error states |
| sun/sun-ui/src/i18n/locale-en.json | Added English translations for OIDC login messages and error states |
| sun/sun-ui/src/App.vue | Updated login UI to include OIDC authentication option and error handling |
| sun/sun-api/methods/authentication.go | Implemented complete OIDC authentication backend with secure state management and token exchange |
| sun/sun-api/main.go | Added OIDC API endpoints to the router configuration |
| sun/sun-api/configuration/configuration.go | Added OIDC configuration structure for provider settings |
| go.mod | Added required OIDC and OAuth2 dependencies |
| deploy/ansible/roles/sun/templates/sun-api-conf.j2 | Added OIDC configuration template for deployment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 12 changed files in this pull request and generated 5 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Reference: