updated server command line options with --listen#198
Open
ntalentac wants to merge 2 commits intonetsec-ethz:masterfrom
Open
updated server command line options with --listen#198ntalentac wants to merge 2 commits intonetsec-ethz:masterfrom
ntalentac wants to merge 2 commits intonetsec-ethz:masterfrom
Conversation
fixed now missing cli option. The -p no longer exists.
FR4NK-W
requested changes
Feb 13, 2023
Contributor
FR4NK-W
left a comment
There was a problem hiding this comment.
Thanks for your contribution and noticing that the scion-bwtestserver now only uses the --listen flag.
The -s flag still exists and is used by the scion-bwtestclient.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions / 0 of 1 LGTMs obtained / 0 of 1 approvals obtained
content/apps/bwtester.md line 24 at r1 (raw file):
scion-bwtestclient -p
scion-bwtestclient in the latest version (3.3.1) is still using the -s flag to specify the server address.
Code quote:
-p content/apps/bwtester.md line 50 at r1 (raw file):
where
-pspecifies your server port.
please also update the comment
Suggestion:
where `--listen` specifies the server (optional address and) port.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed now missing cli option. The -p no longer exists.
This change is