Skip to content

Ensure parse stack is unwound #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlsa merged 2 commits into from
Nov 16, 2025
Merged

Ensure parse stack is unwound #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0176a5b
parse/language: ensure parse stack is unwound
jmb202 Nov 16, 2025
b17f8d3
test: Add test for bad rule in at media block
tlsa Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/parse/language.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,9 +762,6 @@ css_error handleEndBlockContent(css_language *c, const parserutils_vector *vecto
* tokens we have left
*/
ret = handleBlockContent(c, vector);
if (ret != CSS_OK) {
return ret;
}

/* Our goal here is to ensure that the language parse stack is in the
* right state. We've encountered the end of a BlockContent such as
Expand All @@ -783,7 +780,7 @@ css_error handleEndBlockContent(css_language *c, const parserutils_vector *vecto
entry = parserutils_stack_get_current(c->context);
}

return CSS_OK;
return ret;
}

css_error handleDeclaration(css_language *c, const parserutils_vector *vector)
Expand Down
14 changes: 14 additions & 0 deletions test/data/parse2/dodgy-media-block.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,17 @@
| .outer
| top: 0px
#reset

#data
@media screen { b; }
p { padding: 0; }
#errors
#expected
| @media 040
| b
| p
| padding-top: 0px
| padding-right: 0px
| padding-bottom: 0px
| padding-left: 0px
#reset
Loading