Conversation
Contributor
Author
|
Build failures seem unrelated to the PR. I also had to remove deprecation from Compiler::getConfig() as it seems to be only way how can extension access whole config. |
Contributor
Author
|
@dg Are any changes needed or are you just waiting for next release or smth? |
afdbd1f to
3109450
Compare
cb3f8e3 to
694b044
Compare
6043798 to
4f0cb0b
Compare
c27659e to
f575f06
Compare
3803a55 to
11c236b
Compare
24e29f2 to
14bc988
Compare
e841bcc to
9aba53b
Compare
570660e to
dad71aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any key in neon can be validated with neon-defined nette/schema, via
SchemaExtension:Behavior differs from direct use of nette/schema
schema(), eg.Expect::int()->min(10)->max(20)->schema(int(), min(10), max(20))Requirements of schema above could be satisfied with this example configuration:
Keys not defined in schema are allowed and accept any value just like before this PR. So e.g. this is allowed:
TODOs
Big thanks to author of original extension which validates parameters in PHPStan, @ondrejmirtes