Skip to content

Fix small inconsistencies #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kajot-dev wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix small inconsistencies #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
714fbbf
Fix least privilege roles getting trimmed when autogenerate is disabled
Kajot-dev Jan 28, 2026
6f6ef93
Fix manager talking to the wrong service
Kajot-dev Jan 28, 2026
b7794f4
Fix ArgoCD inconsistencies
Kajot-dev Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/core/templates/manager-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ spec:
- name: MANAGER_SERVER_PORT
value: "{{ .Values.manager.svc.mgrServerPort}}"
- name: CTRL_SERVER_IP
value: neuvector-svc-controller.{{ .Release.Namespace }}
value: neuvector-svc-controller-api.{{ .Release.Namespace }}
{{- if not .Values.manager.env.ssl }}
- name: MANAGER_SSL
value: "off"
Expand Down
2 changes: 1 addition & 1 deletion charts/core/templates/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ rules:
- create
- get
- update
{{- end }}
---
{{- if $oc3 }}
apiVersion: authorization.openshift.io/v1
Expand Down Expand Up @@ -153,4 +154,3 @@ rules:
- create
- update
- patch
{{- end }}
8 changes: 4 additions & 4 deletions charts/core/templates/rolebinding-least.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,9 @@ subjects:

---

kind: SecurityContextConstraints
metadata:
name: neuvector-scc-controller
allowHostDirVolumePlugin: false
allowHostIPC: false
allowHostNetwork: false
Expand All @@ -236,9 +239,6 @@ defaultAddCapabilities: null
fsGroup:
type: RunAsAny
groups: []
kind: SecurityContextConstraints
metadata:
name: neuvector-scc-controller
priority: null
readOnlyRootFilesystem: false
requiredDropCapabilities:
Expand All @@ -251,11 +251,11 @@ supplementalGroups:
type: RunAsAny
users: []
volumes:
- azureFile
- configMap
- downwardAPI
- emptyDir
- persistentVolumeClaim
- azureFile
- projected
- secret

Expand Down