NVSHAS-10244: Set env var RANCHER_CLUSTER_NAME for Rancher SSO deployment#549
Merged
williamlin-suse merged 1 commit intoneuvector:masterfrom Mar 13, 2026
Merged
Conversation
holyspectral
requested changes
Mar 13, 2026
Contributor
holyspectral
left a comment
holyspectral
left a comment
There was a problem hiding this comment.
We should also update values.yaml and values.schema.json, so global.cattle.clusterName can be supported.
Comment on lines
162
to
164
| - name: RANCHER_CLUSTER_NAME | ||
| value: "{{ .Values.global.cattle.clusterName }}" | ||
| {{- end }} |
Contributor
There was a problem hiding this comment.
We should keep the RANCHER_CLUSTER_NAME out of the .Values.controller.ranchersso.enabled so if sso is not enabled the envvar would still be set.
Suggested change
| - name: RANCHER_CLUSTER_NAME | |
| value: "{{ .Values.global.cattle.clusterName }}" | |
| {{- end }} | |
| {{- end }} | |
| - name: RANCHER_CLUSTER_NAME | |
| value: "{{ .Values.global.cattle.clusterName }}" |
williamlin-suse
force-pushed
the
NVSHAS-10244
branch
from
c7f59a0 to
462ab6a
Compare
holyspectral
approved these changes
Mar 13, 2026
Contributor
holyspectral
left a comment
holyspectral
left a comment
There was a problem hiding this comment.
LGTM.
@selvamt94 @venkateshjayagopal FYI. let's give it some tests before rancher chart release.
williamlin-suse
force-pushed
the
NVSHAS-10244
branch
from
462ab6a to
e536fbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix neuvector/neuvector#2231