Open
Conversation
Modify `CLOS.isA` to check with `instanceof` instead of `===`. Fix `CLOS.call` by giving the `apply` method a scope. Fix type in tests.js. All tests passes! Yaahoo
…le with the protocol given to defClass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. I don't know if you are still interested in this, but I made some commits to your js-clos project. This pull-req is just to let you know about it.
The changes include:
foo(x, y, z)instread ofCLOS.call('foo', x, y, z)defGenericanddefMethodto cope with the above changedefGenericreturns a function objectdefMethodtakes the function object instead of its namedefClasswith support for multiple inheritancedefMethodsorts the methods based on specificityI made a gist to show the example use cases: https://gist.github.com/ympbyc/4996968
I apologize this is a huge commit. I hope this is worth reviewing.