Replace polling with database watchers for improved efficiency #160
+358
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add tracking watcher alongside existing beads watcher - Initialize tracking watcher for .co/tracking.db monitoring - Subscribe to tracking database change events in Init() - Handle tracking watcher events to reload work tiles on database changes
- Remove startPeriodicRefresh() function and all references - Remove planTickMsg type and handler - Rely on database watchers for event-driven updates instead of 5-second polling - Remove unused time import from tui_plan_data.go
- Use tracking database watcher to detect changes instead of ticker-based polling - Process scheduled tasks on database change events - Keep 30-second safety net timer for due tasks between DB changes - Fall back to polling if watcher initialization fails - Extract processDueTasks function for reuse
- Use tracking database watcher to detect task status changes instead of 2-second ticker - Extract checkTaskStatus helper function for reuse - Fall back to polling if watcher initialization fails - Log which monitoring approach is being used
- Reduce spinnerWait maximum duration from 5-10 seconds to 2 seconds - Leverage database watchers already in place for scheduler and Claude monitoring - Main loop polling is now just a safety net with faster response times - Database events trigger immediate task processing through watchers
- Document converted patterns (TUI, scheduler, Claude, orchestrator) - Explain why certain patterns should stay as polling: - Activity tracker heartbeat (time-based, not event-driven) - GitHub API polling (external API limitations) - User-facing poll command (explicit user expectation) - Test utilities (simplicity and isolation) - Zellij status checks (external process monitoring) - Provide guidelines for future polling vs watcher decisions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces inefficient polling mechanisms with database watchers throughout the codebase, significantly improving responsiveness and reducing resource usage. The changes provide real-time updates for TUI, task scheduling, and Claude task completion monitoring while maintaining necessary polling for external APIs and time-based operations.
Changes
Database Watcher Implementation
TUI Integration: Added tracking database watcher to
cmd/tui_plan.gofor real-time work/task updatesScheduler Optimization: Replaced polling in
cmd/scheduler_handler.gowith database watcherClaude Task Monitoring: Replaced 2-second polling in
internal/claude/inline.goPerformance Optimizations
Documentation
docs/polling-patterns.mdIssues Resolved
Performance Impact
Testing Performed
Breaking Changes
None. All changes are backward compatible and include fallback mechanisms.
Review Notes
Files Modified
cmd/orchestrate.go- Reduced polling intervalscmd/scheduler_handler.go- Added database watcher integrationcmd/tui_plan.go- Integrated tracking watchercmd/tui_plan_data.go- Removed periodic refresh logicinternal/claude/inline.go- Replaced polling with watcherdocs/polling-patterns.md- New documentation fileCo-Authored-By: Claude Opus 4.1 noreply@anthropic.com