Skip to content

Check NXfield arguments #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rayosborn merged 4 commits into from
Feb 17, 2026
Merged

Check NXfield arguments #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b364883
Add the NXgoniometer class to NXinstrument
rayosborn Feb 9, 2026
ffc5113
Filter keyword arguments with a value of None
rayosborn Feb 9, 2026
b38c65f
Update NXentry
rayosborn Feb 17, 2026
68878e1
Merge branch 'update-base-classes' into check-NXfield-arguments
rayosborn Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/nexusformat/definitions/base_classes/NXentry.nxdl.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@
A small image that is representative of the entry. An example of this is a 640x480
jpeg image automatically produced by a low resolution plot of the NXdata.
</doc>
<attribute name="type">
<attribute name="type" deprecated="Use the `type` field instead">
<doc>The mime type should be an ``image/*``</doc>
<enumeration>
<!--
Expand Down
1 change: 1 addition & 0 deletions src/nexusformat/definitions/base_classes/NXinstrument.nxdl.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
<group type="NXfermi_chopper" />
<group type="NXfilter" />
<group type="NXflipper" />
<group type="NXgoniometer" />
<group type="NXguide" />
<group type="NXhistory"/>
<group type="NXinsertion_device" />
Expand Down
2 changes: 1 addition & 1 deletion src/nexusformat/nexus/tree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2912,7 +2912,7 @@ def __init__(self, value=None, name='unknown', shape=None, dtype=None,
if v is not None)
if attrs is None:
attrs = {}
attrs.update(kwargs)
attrs.update({k: v for k, v in kwargs.items() if v is not None})
self._attrs = AttrDict(self, attrs=attrs)
self._memfile = None
self._uncopied_data = None
Expand Down