Support for optional & recommended NXDL attributes#51
Open
takluyver wants to merge 1 commit intonexpy:mainfrom
Open
Support for optional & recommended NXDL attributes#51takluyver wants to merge 1 commit intonexpy:mainfrom
takluyver wants to merge 1 commit intonexpy:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the NXDL docs, an
optional="true"attribute on a field or a group "is equivalent to minOccurs=0", whilerecommended="true"is "A synonym for optional, but with the recommendation that this field be specified."This avoids recording an error in these cases, with a warning for recommended items. I have tested this by validating a file with the [NXmx application definition], and I get fewer errors after the change, with some of them replaced by warnings.
Closes #50