use okhttp client for caching (instead of glide)#1281
Draft
David-Development wants to merge 1 commit intomasterfrom
Draft
use okhttp client for caching (instead of glide)#1281David-Development wants to merge 1 commit intomasterfrom
David-Development wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: David Luhmer <david-dev@live.de>
Member
Author
|
@tobiasKaminsky FYI - I saw that you were involved in the dicussion in bumptech/glide#1847. I think by using the OkHttp Client we can get around the issues with ETags / Last-Modfied without having to initiate a separate http request. But then again... this requires OkHttp which you are not using in the files app yet, eh? |
Member
|
Nice idea! |
Unpublished
requested changes
Mar 17, 2024
| } catch (UnsupportedEncodingException e) { | ||
| e.printStackTrace(); | ||
| } | ||
| body = URLEncoder.encode(debugInfo, StandardCharsets.UTF_8); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR disables Glides Caching and uses OkHttp's caching instead. The reason is that Glide does not care about ETags and Last-Modified Headers. Once a URL is in the cache it stays there. See: bumptech/glide#1847
Fixes #1247
Changes:
DiskCacheStrategyis nowNONE- only favicons override this settingTODO: