fix(propagator): Improve lock behavior of propagator#58134
Merged
AndyScherzinger merged 2 commits intomasterfrom Feb 9, 2026
Merged
fix(propagator): Improve lock behavior of propagator#58134AndyScherzinger merged 2 commits intomasterfrom
AndyScherzinger merged 2 commits intomasterfrom
Conversation
CarlSchwan
added
3. to review
CarlSchwan
requested review from
Altahrim,
ArtificialOwl,
come-nc and
icewind1991
and removed request for
a team
CarlSchwan
commented
Feb 6, 2026
CarlSchwan
force-pushed
the
carl/lock-propagator-order
branch
from
bb7bf2a to
3025dca
Compare
salmart-dev
reviewed
Feb 6, 2026
salmart-dev
reviewed
Feb 9, 2026
CarlSchwan
force-pushed
the
carl/lock-propagator-order
branch
from
4004141 to
4240de3
Compare
Fix possible dead locks when running the propagator caused by two requests updating the same amount rows in transactions. - Lock rows always in the same deterministic order by sorting the path_hash first - On all database outside of sqlite, also do first a SELECT FOR UPDATE to lock all the rows used in batch UPDATE calls, afterward to decrease the risk of two requests trying to lock the same rows Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/lock-propagator-order
branch
from
4240de3 to
95b3bd9
Compare
salmart-dev
approved these changes
Feb 9, 2026
Member
Author
|
/backport to stable33 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix possible dead locks when running the propagator caused by two requests updating the same amount rows in transactions.
Lock rows always in the same deterministic order by sorting the path_hash first
On all database outside of sqlite, also do first a SELECT FOR UPDATE to lock all the rows used in batch UPDATE calls, afterward to decrease the risk of two requests trying to lock the same rows
Summary
TODO
Checklist
3. to review, feature component)stable32)