fix: Remove deprecated RFC7231 constant to avoid warnings on PHP 8.5#58201
Open
DerDreschner wants to merge 1 commit intomasterfrom
Open
fix: Remove deprecated RFC7231 constant to avoid warnings on PHP 8.5#58201DerDreschner wants to merge 1 commit intomasterfrom
DerDreschner wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>
DerDreschner
requested review from
Altahrim,
ArtificialOwl,
ChristophWurst,
SebastianKrupinski,
kesselb,
leftybournes and
salmart-dev
and removed request for
a team
Contributor
|
Add it as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since PHP 8.5, the RFC7231 constant is being deprecated (see PHP wiki). This produces deprecation warnings in several cases (in my case: when running the Mail app unit tests).
PHP Deprecated: Constant DateTimeInterface::RFC7231 is deprecated since 8.5, as this format ignores the associated timezone and always uses GMT in /var/www/html/lib/public/AppFramework/Http/Response.php on line 101To fix that, I replaced the constant with the value that's being used instead. This should be fine as we rely on GMT anyway here. If not, please let me know!
Checklist
3. to review, feature component)stable32)