fix(CallActivity): check participant's nextcloud session ids if not MCU #5681
+9
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
/backport to stable-22.0 am i doing this right |
xandris
force-pushed
the
bugfix/5452-call-dropped-with-hpb
branch
2 times, most recently
from
5e8026a to
0be6e1c
Compare
The logic in CallActivity ends up comparing our nextcloud session id to the call session ID when handling a "call participants changed" message. If hasMCU, then compare call session IDs, otherwise compare nextcloud session IDs. See: nextcloud#5452 Signed-off-by: Alexandra Parker <alex@etherbunny.net>
xandris
force-pushed
the
bugfix/5452-call-dropped-with-hpb
branch
from
0be6e1c to
1046c84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic in CallActivity ends up comparing our nextcloud session id to the call session ID when handling a "call participants changed" message. If hasMCU, then compare call session IDs, otherwise compare nextcloud session IDs.
See: #5452
🏁 Checklist
/backport to stable-xx.x