Skip to content

edit captions #5686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sowjanyakch wants to merge 4 commits into
base: master
Choose a base branch
from
Open

edit captions #5686

sowjanyakch wants to merge 4 commits into from

Conversation

@sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Jan 6, 2026 •
edited
Loading

fix #5685

  • edit captions
  • show time, edited tag and checkmark for attachment messages.
  • editing captions with mentions also work

🖼️ Screenshots

edited message

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch self-assigned this Jan 6, 2026
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Jan 6, 2026
@sowjanyakch
edit captions
a86f9ca 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
modify incoming and outcoming preview holders
3ef8da8 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
add edit timestamps
90b7f2d 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch
remove extra spacing + format
ed8e1b1 
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch sowjanyakch force-pushed the fix/5685/EditCaptions branch from 9825e02 to ed8e1b1 Compare January 6, 2026 18:08
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5686.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

Codacy

Lint

TypemasterPR
Warnings9997
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181
 org.jetbrains.annotations.NotNull is used. Please use androidx.annotation.NonNull instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi Awaiting requested review from mahibi

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

At least 1 approving review is required to merge this pull request.

Assignees

@sowjanyakch sowjanyakch

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Captions must also be editable

2 participants

@sowjanyakch