Replace dependency on moment with dayjs #3027
Conversation
Following nextcloud/server#57503, this saves about 15% of the zipped bundle size for Tasks. Signed-off-by: Alan Savage <3028205+asavageiv@users.noreply.github.com>
|
Thanks for the PR. Unfortunately, some unit tests related to moment now fail. |
|
I fixed the tests, but I think this needs more work. One difference between Moment and DayJS is that DayJS dates are immutable. There means that where before this would have worked: due.add(start.diff(currentstart), 'ms')it now needs to be due = due.add(start.diff(currentstart), 'ms')It doesn't look like the tests cover all these cases, so I will have to add some more tests and work my way through them manually. |
Signed-off-by: Alan Savage <3028205+asavageiv@users.noreply.github.com>
asavageiv
force-pushed
the
tasks-nomoment
branch
from
f903475 to
37718a7
Compare
Signed-off-by: Alan Savage <3028205+asavageiv@users.noreply.github.com>
|
Ok, I think this is good to go now. |
raimund-schluessler
added
dependencies
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
2 participants
Following nextcloud/server#57503, this saves about 15% of the zipped bundle size for Tasks.