Update user_sql for Nextcloud 30, add optional feature for deleted users#198
Open
ApolloLV wants to merge 16 commits intonextcloud:masterfrom
Open
Update user_sql for Nextcloud 30, add optional feature for deleted users#198ApolloLV wants to merge 16 commits intonextcloud:masterfrom
ApolloLV wants to merge 16 commits intonextcloud:masterfrom
Conversation
Merge stable branch into the master branch
bump to NC29
…rop/user_sql into rotdrop-production/cafevdb/stable30
…ies" This reverts commit ea60557 since we can achieve the same thing with the active instead of disabled column
Revert Remove the filtering for blocked users
|
I'm just a user here. We also upgraded to NC 30.0.1 just now. Have not applied this patch (yet). @ApolloLV I'm curious about the placeholder_users feature that you introduced in this PR. You mention without this there are "issues due to uncertain ownership". I suppose this fixes something if the user was not actively deleted from within Nextcloud user management or via the occ tool... but removed/disabled in the SQL table? We make that "mistake" too sometimes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We tested our modifications of the source code of user_sql (based on the fork https://github.com/rotdrop/user_sql).
In our testing we found that it still works reliably with newer Nextcloud versions (27+), and as such we would request that the compatibility of the app is updated to indicate it works for NC25-NC30.
The code has been brought up-to-date with NC30 requirements.
We also added an optional feature to the plugin that prevents issues if users that have shared files with other users are deleted in the SQL database (or marked as disabled), as the existing shared files will have issues due to uncertain ownership in newer Nextcloud versions.