Fix resolution of nested Groovy class in v2 parser#6744
Merged
bentsherman merged 3 commits intomasterfrom Jan 23, 2026
Merged
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
pditommaso
approved these changes
Jan 22, 2026
jorgee
approved these changes
Jan 22, 2026
Member
Author
|
@jorgee there are some unit tests failing that seem to be related to #6733 , which is strange since they didn't fail when merged to master (24b858d) I wonder if they are flaky tests. Can you look into this? |
Contributor
|
It looks like there was a temporary failure in Github. All errors are sush as the following |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the v2 script parser could resolve a Groovy class like
groovy.json.JsonSlurperbut not a nested class likegroovy.json.JsonGenerator.OptionsThe issue was surfaced by ongoing efforts to make nf-test work with strict syntax: askimed/nf-test#336