nmc/minor-size-and-style-fixing #434
Merged
+161
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enforce consistent 40x40px dimensions for sharing popup and three-dot menu buttons in file list by adding !important flags and min-width/min-height constraints to prevent size changes during user interactions.
- Change sharing button to transparent background with border in normal state - Add white border and icon in dark mode - Update hover state with blue background and different colors for light/dark modes - Add pressed state with blue pressed color - Configure active/existing share state with primary blue - Update focus state with colored outline rings (black for light mode, white for dark mode) - Ensure action menu dots icon stays black in both modes
- Update action menu toggle button to match sharing button styling - Add transparent background with border for normal state - Configure different colors for light and dark modes across all states - Implement hover, pressed, active, and focus states with appropriate colors - Ensure icons remain black in interactive states for both themes
- Hide inline SVGs with hardcoded colors in action buttons - Apply custom file type icons for each button based on position - Replace checkmark with folder icon for selected state - Ensure icons adapt to light/dark theme
- Add custom checkmark.svg to replace default folder icon in selected state - Add custom music.svg to replace default audio file type icon - Update icon generation system to include new custom icons - Update action button styles to use custom icons with proper dark mode support - Replace inline SVG icons with background-image approach for better theming
- Move common .icon-vue properties (background positioning, size, svg hiding) to shared block - Consolidate pressed icon styling into single section - Condense nth-child icon assignments to single-line format for better readability - Fix checkmark icon selector to properly target aria-checked state
Using width/height instead of display:none allows the element to act as padding spacing for buttons without icons. This provides consistent button layout while maintaining the ability to control spacing.
Changed the quick share options dropdown button styling: - Updated text color from #2E466A to #2238DF - Replaced CSS filter approach with mask property for eye and calendar icons - Icons now use CSS mask with background-color for consistent color rendering across light and dark themes
Changed the 'Create new link' button text color to use --telekom-color-ui-black for improved readability and consistency with design system standards.
Removed custom icon background assignments and unnecessary style overrides. Icons now use standard SVG rendering with proper color inheritance from design system variables.
Cleaned up checkmark and music SVG icons that are no longer needed after switching to standard icon rendering. Removed whitespace from action button styles.
memurats
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.