Conversation
Important! Template update for nf-core/tools v3.0.2
|
mashehu
reviewed
Dec 2, 2024
|
@matq007 Do you need some help to finalize this release? :) |
Member
Author
|
I just need a PR review, the pipeline is works locally ^_^ |
|
But there are three tests which are marked as required and are not running? |
famosab
reviewed
Mar 12, 2025
There was a problem hiding this comment.
Left a couple of questions. My main thing would be:
Try to do changes that go into the changelog in small PRs (like a new subworkflow) - these are easily reviewable. To me it seems that many commits went into this release PR but these were not reviewed in the meantime (?).
And use nf-core pipelines bump-version to update to a version for the release. I would also suggest to include the release name in the changelog. https://www.codenamegenerator.com/ can be used for name finding :)
Member
Author
|
Hi @famosab, I assume the reason behind failed execution is because of changes from nf-core template which marsseq if quite behind. Would be easier to merge the latest PR to this as well? It will be however a huge PR then, but I can split the this next merging to smaller commit. Let me know what you think. |
|
I would recommend a PR from a feature branch to dev which incorporates the new changes :) That way each change will be a bit smaller and easier to track? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).