Skip to content

Conversation

@mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Dec 2, 2025

close #3953

Done:

  • New function to run nextflow inspect and obtain docker config file
  • New function to (re)generate all container config files
  • Container config files are regenerated with nf-core modules install|update|remove

TODO:

  • Add tests
  • Test a lot
  • What happens if the module is not found?
    • Modules form multiple repos
    • Modules included as an alias
  • Is there a case where two modules have the same name but different container? how to solve this? We couldn't find an existing case of this
  • Could the code be used to reduced duplication with download command?

@mirpedrol mirpedrol force-pushed the pipeline-container-config-builder branch from 6341cd3 to b8004aa Compare December 2, 2025 14:43
mirpedrol and others added 3 commits December 4, 2025 14:59
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
@mirpedrol mirpedrol marked this pull request as ready for review December 4, 2025 14:39
mirpedrol and others added 2 commits December 15, 2025 15:04
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 97.01493% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.76%. Comparing base (a70e6f2) to head (bd98209).
⚠️ Report is 13 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/pipelines/containers_utils.py 96.29% 2 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mirpedrol mirpedrol changed the title [WIP] Command to generate pipeline container config files Command to generate pipeline container config files Dec 16, 2025
@mashehu mashehu mentioned this pull request Dec 16, 2025
11 tasks
return None


def try_generate_container_configs(directory: Path, path: Path):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def try_generate_container_configs(directory: Path, path: Path):
def generate_container_configs(directory: Path, path: Path):

"""Generates the container configuration files for a pipeline.

Args:
workflow_directory (str | Path): The directory containing the workflow files.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
workflow_directory (str | Path): The directory containing the workflow files.
workflow_directory (Path): The directory containing the workflow files.

)
{% if multiqc %}ch_multiqc_files = ch_multiqc_files.mix(FASTQC.out.zip.collect{it[1]}){% endif %}
ch_versions = ch_versions.mix(FASTQC.out.versions.first())
{% if multiqc %}ch_multiqc_files = ch_multiqc_files.mix(FASTQC.out.zip.collect{it -> it[1]}){% endif %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% if multiqc %}ch_multiqc_files = ch_multiqc_files.mix(FASTQC.out.zip.collect{it -> it[1]}){% endif %}
{% if multiqc %}ch_multiqc_files = ch_multiqc_files.mix(FASTQC.out.zip.collect{file -> file[1]}){% endif %}

@mashehu mashehu force-pushed the pipeline-container-config-builder branch from f115b17 to bfc916b Compare January 22, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants