Fix conflicting AddLinkedResource method signatures#55
Closed
Copilot wants to merge 2 commits intofeature/cid-supportfrom
Closed
Fix conflicting AddLinkedResource method signatures#55Copilot wants to merge 2 commits intofeature/cid-supportfrom
Copilot wants to merge 2 commits intofeature/cid-supportfrom
Conversation
…s to use new API Co-authored-by: nfMalde <5366984+nfMalde@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update CID support for inline images in emails
Fix conflicting AddLinkedResource method signatures
Jan 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interface
IAttachmentCollectiondefined two overloads ofAddLinkedResourcefor byte arrays that conflicted due to having the same parameter types in different order, causing a compilation error.Changes:
AddLinkedResource(byte[], string fileName, string contentType, string contentId)signature from interfaceAddLinkedResource(byte[], string contentType, string contentId, string? fileName = null)AttachmentCollection.csto match new signatureAPI Change:
The new signature follows the pattern established by other
AddLinkedResourceoverloads (contentType before contentId) and makes fileName optional.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.