fix: Honor ContentType parameter for FilePath-based linked resources#56
Merged
nfMalde merged 2 commits intofeature/cid-supportfrom Jan 4, 2026
Merged
fix: Honor ContentType parameter for FilePath-based linked resources#56nfMalde merged 2 commits intofeature/cid-supportfrom
nfMalde merged 2 commits intofeature/cid-supportfrom
Conversation
Co-authored-by: nfMalde <5366984+nfMalde@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add CID support for inline images in email
fix: Honor ContentType parameter for FilePath-based linked resources
Jan 4, 2026
nfMalde
approved these changes
Jan 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the contentType parameter was ignored when adding FilePath-based linked resources, causing them to always use auto-detected content types instead of the explicitly specified type.
Key Changes:
- Modified FilePath-based linked resource handling to read file bytes and pass explicit content type to MimeKit
- Aligned implementation with existing FileUrl and FileBytes handler patterns
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling
AddLinkedResource(string filePath, string contentType, string contentId, string? fileName = null), thecontentTypeparameter was stored but ignored during MIME message construction, causing linked resources to always use auto-detected content types.Changes
contentTypetobodyBuilder.LinkedResources.Add(), matching the pattern used by FileUrl and FileBytes handlersMimeKit.MimeTypes.GetMimeType()whencontentTypeis nullExample
Previously, the image would be added with MIME type detected from
.binextension. Now it correctly usesimage/png.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.