Skip to content

Conversation

@quisquous
Copy link

No description provided.

@quisquous
Copy link
Author

quisquous commented Sep 12, 2020

I am not sure this approach is reasonable, because how do downstream dependencies that are using the IOverlayPreset supposed to compile? Do they need to be updated ahead of time?

Another alternative is to add more strings into Supports, but that felt a little bit hacky.

Do you have suggestions on better ways to get at this? Maybe RegisterOverlayPreset could take a JObject instead of an IOverlayPreset as a way to have a looser coupling?

@ngld
Copy link
Owner

ngld commented Dec 10, 2020

Using JObjects sounds like a good solution. The default presets are already read through Newtonsoft.Json, I'd have to modify the code that parses the JSON data but then I could use it for both RegisterOverlayPreset and the presets.json file.

Oh, and sorry for the late response. I didn't check GitHub for the past two months...

sandtechnology pushed a commit to sandtechnology/OverlayPlugin that referenced this pull request May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants