Support building with newer ffxiv plugin versions #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Language.Unknown and calls to ToProperCase. Additionally, stop proper casing 6.x versions (intl and chinese) as the ffxiv plugin has stopped proper casing names there. This caused problems in cactbot where names no longer matched, so doing it here as well for consistency. Split from #235 to make this easier to land.
quisquous
changed the title
quisquous
added a commit
to OverlayPlugin/OverlayPlugin
that referenced
this pull request
Aug 19, 2022
Remove Language.Unknown and calls to ToProperCase. Additionally, stop proper casing 6.x versions as the ffxiv plugin has stopped proper casing names there. This caused problems in cactbot where names no longer matched, so doing it here as well for consistency. Split from ngld#235 to make this easier to land. This is a copy of ngld#258 applied to this fork.
quisquous
added a commit
to OverlayPlugin/OverlayPlugin
that referenced
this pull request
Aug 19, 2022
Remove Language.Unknown and calls to ToProperCase. Additionally, stop proper casing 6.x versions as the ffxiv plugin has stopped proper casing names there. This caused problems in cactbot where names no longer matched, so doing it here as well for consistency. Split from ngld#235 to make this easier to land. This is a copy of ngld#258 applied to this fork.
ngld
pushed a commit
that referenced
this pull request
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Language.Unknown and calls to ToProperCase.
Additionally, stop proper casing 6.x versions (intl and chinese)
as the ffxiv plugin has stopped proper casing names there.
This caused problems in cactbot where names no longer matched,
so doing it here as well for consistency.
Split from #235 to make this easier to land.