Add support for SHA-256 #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example in RtspCameraExample\RtspServer.cs Will send either WWW-Authenticate with an algorithm of MD5 (the default) or WWW-Authenticate with an alogirutm of SHA-256 Tested with a patched FFmpeg TODO Some ONVIF cameras now support RTSP where they send _both_ WWW-Authenticate headers with MD5 first, and SHA-256 second. This is not yet supported. a) send a WWW-Authenticate with
Old code use MD5
use "using" and raw string when there is a lot of "
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ONVIF Standard now includes SHA-256 as well as MD5 for Digest Authentication.
This change adds the ability to enable SHA-256 in the RtspCameraExample code.
It is tested with a patched ffmpeg library which adds SHA-256
There is one more change to follow, but that will be in a different PR.
That is where we have multiple WWW-Authenticate headers and tell RTSP clients that we can do both MD5 and SHA256, like some HikVision camera have, but that is for another time.
It has been a long time since I've done any Unit Tests so just wanted someone to cast their eye over this.
Thanks
Roger