Allow Reader in addition to String and java.io.File#7
Open
daveliepmann wants to merge 2 commits intongrunwald:masterfrom
Open
Allow Reader in addition to String and java.io.File#7daveliepmann wants to merge 2 commits intongrunwald:masterfrom
daveliepmann wants to merge 2 commits intongrunwald:masterfrom
Conversation
Per docstring, `uri` should accept Readers like from clojure.java.io/reader.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per
read-csv's docstring, parameterurishould be able to be a Reader such as fromclojure.java.io/reader. This PR makes that possible. My use case is something like:Ideally meta-csv would accept
java.net.URLso that the resource could be read directly, but that isn't currently listed as an acceptable parameter. But adding(instance? java.net.URL uri)to thisorwould actually solve my use case more directly.(I did not look into InputStreams but there may be a similar issue there.)