This repository was archived by the owner on Aug 24, 2022. It is now read-only.
allow passing response-predicate to wrap-restful-format#60
Open
ninjudd wants to merge 1 commit intongrunwald:masterfrom
Open
allow passing response-predicate to wrap-restful-format#60ninjudd wants to merge 1 commit intongrunwald:masterfrom
ninjudd wants to merge 1 commit intongrunwald:masterfrom
Conversation
|
Just got bitten hard by this issue - LGTM please? |
|
The alternative is in format_params.clj:273, the |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is the best fix for it, but right now, there is no way to pass
:predicatetowrap-restful-format, because it ends up getting passed to bothwrap-restful-paramsandwrap-restful-response, which doesn't work.In my case, I only need to pass a predicate to
wrap-restful-response, so I made thatwrap-format-responseaccept:response-predicateand prefer that over:predicate.There's probably a better way to solve this issue. I'm open to suggestions.