Lazy register of SpringConfiguration#10
Open
BernhardBln wants to merge 1 commit intonhuray:masterfrom
Open
Conversation
In case you use the AnnotatedSpringConfiguration and construct beans that need the Dropwizard Configuration or Environment. Those beans cannot be instantiated when you create the context, as the registration of the dropwizard configuration and environment as singletons into the context happens after the beans would be constructed. There is now an additional constructor in the SpringBundle which allows you to hand over the annotated Spring configuration class, which then gets registered with the context after those singletons got registered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case you use the AnnotatedSpringConfiguration
and construct beans that need the Dropwizard
Configuration or Environment.
Those beans cannot be instantiated when you create
the context, as the registration of the dropwizard
configuration and environment as singletons into the
context happens after the beans would be constructed.
There is now an additional constructor in the SpringBundle
which allows you to hand over the annotated Spring configuration
class, which then gets registered with the context after
those singletons got registered.