CI Bundle #2 - Passing

.github/actionlint.yaml

@@ -1,3 +1,4 @@
 self-hosted-runner:
   labels:
     - icon-editor-windows
+    - self-hosted-windows-lv

.github/workflows/ci.json

@@ -46,7 +46,7 @@
         {
           "run": "npm run generate:summary",
           "env": {
-            "TEST_RESULTS_GLOB": "test-results/*junit*.xml"
+            "TEST_RESULTS_GLOBS": "test-results/*junit*.xml"
           }
         },
         {
@@ -83,12 +83,17 @@
             {
               "os": "ubuntu-24.04",
               "runs-on": "ubuntu-24.04",
-              "runner_type": "default"
+              "runner_type": "linux"
             },
             {
-              "os": "windows-latest",
-              "runs-on": "windows-latest",
+              "os": "self-hosted-windows-lv",
+              "runs-on": "self-hosted-windows-lv",
               "runner_type": "integration"
+            },
+            {
+              "os": "self-hosted-windows-lv",
+              "runs-on": "self-hosted-windows-lv",
+              "runner_type": "default"
             }
           ]
         }
@@ -102,22 +107,22 @@
           "uses": "actions/checkout@v4"
         },
         {
-          "name": "Install PowerShell 7.5.1",
-          "if": "matrix.os == 'windows-latest'",
+          "name": "Ensure PowerShell 7.5.1",
+          "if": "matrix.runner_type != 'linux'",
           "shell": "pwsh",
-          "run": "$expectedBuild = '10.0.20348'\n$build = (Get-ComputerInfo).OsVersion\nif ($build -ne $expectedBuild) {\n  throw \"Unexpected OS build: $build\"\n}\n$msiUrl = 'https://github.com/PowerShell/PowerShell/releases/download/v7.5.1/PowerShell-7.5.1-win-x64.msi'\n$msiPath = Join-Path $env:RUNNER_TEMP 'PowerShell-7.5.1-win-x64.msi'\nInvoke-WebRequest -Uri $msiUrl -OutFile $msiPath\n$expectedHash = 'b110eccaf55bb53ae5e6b6de478587ed8203570b0bda9bd374a0998e24d4033a'\n$actualHash = (Get-FileHash $msiPath -Algorithm SHA256).Hash\nif ($actualHash -ne $expectedHash) {\n  throw \"SHA256 mismatch: $actualHash\"\n}\nStart-Process msiexec -Wait -ArgumentList '/i', $msiPath, '/qn', 'ADD_PATH=1'\n$version = (pwsh --version).Trim() -replace '^PowerShell '\nif ($version -ne '7.5.1') {\n  throw \"PowerShell version $version is not 7.5.1\"\n}\n"
+          "run": "$required = [Version]'7.5.1'\nif ($PSVersionTable.PSVersion -lt $required) {\n  $msiUrl = 'https://github.com/PowerShell/PowerShell/releases/download/v7.5.1/PowerShell-7.5.1-win-x64.msi'\n  $msiPath = Join-Path $env:RUNNER_TEMP 'PowerShell-7.5.1-win-x64.msi'\n  Invoke-WebRequest -Uri $msiUrl -OutFile $msiPath\n  $expectedHash = 'b110eccaf55bb53ae5e6b6de478587ed8203570b0bda9bd374a0998e24d4033a'\n  $actualHash = (Get-FileHash $msiPath -Algorithm SHA256).Hash\n  if ($actualHash -ne $expectedHash) {\n    throw \"SHA256 mismatch: $actualHash\"\n  }\n  Start-Process msiexec -Wait -ArgumentList '/i', $msiPath, '/qn', 'ADD_PATH=1'\n}\n$version = (pwsh --version).Trim() -replace '^PowerShell '\nif ([Version]$version -lt $required) {\n  throw \"PowerShell version $version is less than $required\"\n}\n"
         },
         {
           "name": "Capture setup info",
           "shell": "pwsh",
-          "run": "$data = [ordered]@{\n  'Current runner version' = $env:RUNNER_VERSION\n  'Runner Image'          = $env:ImageOS\n  'ImageVersion'          = $env:ImageVersion\n  'RUNNER_NAME'           = $env:RUNNER_NAME\n  'RUNNER_OS'             = $env:RUNNER_OS\n  'RUNNER_ARCH'           = $env:RUNNER_ARCH\n}\n$file = \"setup-info-${{ matrix.os }}.md\"\n\"was captured from the set up job.\" | Out-File -FilePath $file -Encoding utf8\nforeach ($k in $data.Keys) {\n  if ($data[$k]) {\n    \"${k}: $($data[$k])\" | Out-File -FilePath $file -Encoding utf8 -Append\n  }\n}\n"
+          "run": "$data = [ordered]@{\n  'Current runner version' = $env:RUNNER_VERSION\n  'Runner Image'          = $env:ImageOS\n  'ImageVersion'          = $env:ImageVersion\n  'RUNNER_NAME'           = $env:RUNNER_NAME\n  'RUNNER_OS'             = $env:RUNNER_OS\n  'RUNNER_ARCH'           = $env:RUNNER_ARCH\n}\n$file = \"setup-info-${{ matrix.os }}-${{ matrix.runner_type }}.md\"\n\"was captured from the set up job.\" | Out-File -FilePath $file -Encoding utf8\nforeach ($k in $data.Keys) {\n  if ($data[$k]) {\n    \"${k}: $($data[$k])\" | Out-File -FilePath $file -Encoding utf8 -Append\n  }\n}\n"
         },
         {
           "uses": "actions/upload-artifact@v4",
           "if": "always()",
           "with": {
-            "name": "setup-info-${{ matrix.os }}",
-            "path": "setup-info-${{ matrix.os }}.md"
+            "name": "setup-info-${{ matrix.os }}-${{ matrix.runner_type }}",
+            "path": "setup-info-${{ matrix.os }}-${{ matrix.runner_type }}.md"
           }
         },
         {
@@ -139,7 +144,7 @@
           "uses": "actions/upload-artifact@v4",
           "if": "always()",
           "with": {
-            "name": "pester-junit-${{ matrix.os }}",
+            "name": "pester-junit-${{ matrix.os }}-${{ matrix.runner_type }}",
             "path": "pester-results/pester-junit.xml",
             "if-no-files-found": "error"
           }
@@ -152,7 +157,7 @@
         "ps-ci"
       ],
       "runs-on": "ubuntu-24.04",
-      "if": "always()",
+      "if": "(success() || failure()) && !cancelled()",
       "steps": [
         {
           "uses": "actions/checkout@v4"
@@ -184,7 +189,7 @@
             "TEST_RESULTS_GLOBS": "downloaded/test-results/**/*junit*.xml\ndownloaded/pester-junit-*/pester-junit.xml\n",
             "REQ_MAPPING_FILE": "requirements.json",
             "DISPATCHER_REGISTRY": "dispatchers.json",
-            "EVIDENCE_DIR": "test-screenshots"
+            "EVIDENCE_DIR": "downloaded/evidence"
           }
         },
         {

.github/workflows/ci.yml

@@ -25,19 +25,19 @@ jobs:
       - run: npm run derive:registry
       - run: npm run generate:summary
         env:
-          TEST_RESULTS_GLOB: test-results/*junit*.xml
+          TEST_RESULTS_GLOBS: test-results/*junit*.xml
       - uses: actions/upload-artifact@v4
-        if: always()
+        if: ${{ (success() || failure()) && !cancelled() }}
         with:
           name: traceability
           path: ${{ env.ARTIFACT_DIR }}/traceability.*
       - uses: actions/upload-artifact@v4
-        if: always()
+        if: ${{ (success() || failure()) && !cancelled() }}
         with:
           name: action-docs
           path: ${{ env.ARTIFACT_DIR }}/action-docs.*
       - uses: actions/upload-artifact@v4
-        if: always()
+        if: ${{ (success() || failure()) && !cancelled() }}
         with:
           name: evidence
           path: ${{ env.ARTIFACT_DIR }}/evidence/**
@@ -49,31 +49,37 @@ jobs:
         include:
           - os: ubuntu-24.04
             runs-on: ubuntu-24.04
-            runner_type: default
-          - os: windows-latest
-            runs-on: windows-latest
+            runner_type: linux
+          - os: self-hosted-windows-lv
+            runs-on: self-hosted-windows-lv
             runner_type: integration
+          - os: self-hosted-windows-lv
+            runs-on: self-hosted-windows-lv
+            runner_type: default
     runs-on: ${{ matrix.runs-on }}
     env:
       RUNNER_TYPE: ${{ matrix.runner_type }}
     steps:
       - uses: actions/checkout@v4
-      - name: Install PowerShell 7.5.1
-        if: matrix.os == 'windows-latest'
+      - name: Ensure PowerShell 7.5.1
+        if: matrix.runner_type != 'linux'
         shell: pwsh
         run: |
-          $msiUrl = 'https://github.com/PowerShell/PowerShell/releases/download/v7.5.1/PowerShell-7.5.1-win-x64.msi'
-          $msiPath = Join-Path $env:RUNNER_TEMP 'PowerShell-7.5.1-win-x64.msi'
-          Invoke-WebRequest -Uri $msiUrl -OutFile $msiPath
-          $expectedHash = 'b110eccaf55bb53ae5e6b6de478587ed8203570b0bda9bd374a0998e24d4033a'
-          $actualHash = (Get-FileHash $msiPath -Algorithm SHA256).Hash
-          if ($actualHash -ne $expectedHash) {
-            throw "SHA256 mismatch: $actualHash"
+          $required = [Version]'7.5.1'
+          if ($PSVersionTable.PSVersion -lt $required) {
+            $msiUrl = 'https://github.com/PowerShell/PowerShell/releases/download/v7.5.1/PowerShell-7.5.1-win-x64.msi'
+            $msiPath = Join-Path $env:RUNNER_TEMP 'PowerShell-7.5.1-win-x64.msi'
+            Invoke-WebRequest -Uri $msiUrl -OutFile $msiPath
+            $expectedHash = 'b110eccaf55bb53ae5e6b6de478587ed8203570b0bda9bd374a0998e24d4033a'
+            $actualHash = (Get-FileHash $msiPath -Algorithm SHA256).Hash
+            if ($actualHash -ne $expectedHash) {
+              throw "SHA256 mismatch: $actualHash"
+            }
+            Start-Process msiexec -Wait -ArgumentList '/i', $msiPath, '/qn', 'ADD_PATH=1'
           }
-          Start-Process msiexec -Wait -ArgumentList '/i', $msiPath, '/qn', 'ADD_PATH=1'
           $version = (pwsh --version).Trim() -replace '^PowerShell '
-          if ($version -ne '7.5.1') {
-            throw "PowerShell version $version is not 7.5.1"
+          if ([Version]$version -lt $required) {
+            throw "PowerShell version $version is less than $required"
           }
       - name: Capture setup info
         shell: pwsh
@@ -86,18 +92,18 @@ jobs:
             'RUNNER_OS'             = $env:RUNNER_OS
             'RUNNER_ARCH'           = $env:RUNNER_ARCH
           }
-          $file = "setup-info-${{ matrix.os }}.md"
+          $file = "setup-info-${{ matrix.os }}-${{ matrix.runner_type }}.md"
           "was captured from the set up job." | Out-File -FilePath $file -Encoding utf8
           foreach ($k in $data.Keys) {
             if ($data[$k]) {
               "${k}: $($data[$k])" | Out-File -FilePath $file -Encoding utf8 -Append
             }
           }
       - uses: actions/upload-artifact@v4
-        if: always()
+        if: ${{ (success() || failure()) && !cancelled() }}
         with:
-          name: setup-info-${{ matrix.os }}
-          path: setup-info-${{ matrix.os }}.md
+          name: setup-info-${{ matrix.os }}-${{ matrix.runner_type }}
+          path: setup-info-${{ matrix.os }}-${{ matrix.runner_type }}.md
       - name: Install Pester
         shell: pwsh
         run: |
@@ -112,21 +118,23 @@ jobs:
           if (Test-Path "tests/pester") {
             $cfg = New-PesterConfiguration
             $cfg.Run.Path = './tests/pester'
-            $cfg.TestResult.Enabled = $false
+            $cfg.TestResult.Enabled = $true
+            $cfg.TestResult.OutputFormat = 'JUnitXml'
+            $cfg.TestResult.OutputPath = 'pester-results/pester-junit.xml'
             $cfg.Run.Exit = $true
             Invoke-Pester -Configuration $cfg
           }
       - uses: actions/upload-artifact@v4
-        if: always()
+        if: ${{ (success() || failure()) && !cancelled() }}
         with:
-          name: pester-junit-${{ matrix.os }}
+          name: pester-junit-${{ matrix.os }}-${{ matrix.runner_type }}
           path: pester-results/pester-junit.xml
           if-no-files-found: error
 
   report:
     needs: [node-ci, ps-ci]
     runs-on: ubuntu-24.04
-    if: always()
+    if: ${{ (success() || failure()) && !cancelled() }}
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
@@ -145,5 +153,5 @@ jobs:
             downloaded/pester-junit-*/pester-junit.xml
           REQ_MAPPING_FILE: requirements.json
           DISPATCHER_REGISTRY: dispatchers.json
-          EVIDENCE_DIR: test-screenshots
+          EVIDENCE_DIR: downloaded/evidence
       - run: npx tsx scripts/print-pester-traceability.ts >> "$GITHUB_STEP_SUMMARY"

.github/workflows/missing-in-project-self-hosted.json

@@ -15,7 +15,7 @@
           "uses": "./missing-in-project/action.yml",
           "with": {
             "lv_version": "2021",
-            "arch": "64",
+            "supported_bitness": "64",
             "project_file": "scripts/missing-in-project/Missing in Project.lvproj",
             "relative_path": "scripts/missing-in-project"
           }

.github/workflows/missing-in-project-self-hosted.yml

@@ -12,7 +12,7 @@ jobs:
         uses: ./missing-in-project/action.yml
         with:
           lv_version: '2021'
-          arch: '64'
+          supported_bitness: '64'
           project_file: 'scripts/missing-in-project/Missing in Project.lvproj'
           relative_path: 'scripts/missing-in-project'
       - name: Upload missing findings

AGENTS.md

@@ -3,9 +3,12 @@
 ## Environment Setup
 - Run `apt-get update && apt-get install -y apt-utils` to ensure required APT utilities are available.
 - Ensure Node.js 24 or newer is installed (e.g. via the NodeSource setup script).
+  - Verify with `node --version`.
 - Install `actionlint` and ensure it is on your `PATH`:
   - `go install github.com/rhysd/actionlint/cmd/actionlint@latest`
+  - Verify with `actionlint -version`.
 - Ensure PowerShell 7.5.1 is installed and accessible.
+  - Verify with `pwsh --version`.
   - Linux runners rely on preinstalled `pwsh`.
   - On Windows Server 2022 (build 10.0.20348), download the MSI and verify its SHA256 checksum before installing:
 
@@ -18,6 +21,10 @@
     Remove-Item pwsh.msi
     ```
 - PowerShell 7.5.1 includes native YAML support; external modules such as `powershell-yaml` are no longer required.
+- Install NI LabVIEW's command-line interface (g-cli) on Windows runners and ensure it is accessible.
+  - Verify with `g-cli --version` or `& 'C:\\Program Files\\G-CLI\\bin\\g-cli.exe' --version`.
+- Optional: set `LABVIEW_ICON_EDITOR_PATH` if a custom icon editor location is required.
+  - Verify with `echo $LABVIEW_ICON_EDITOR_PATH` (or `$env:LABVIEW_ICON_EDITOR_PATH` in PowerShell).
 
 ## Testing
 - Run `npm run check:node` to verify Node.js satisfies the required version.

README.md

@@ -11,6 +11,8 @@ For setup and action reference, see the [documentation](docs/index.md). The [qui
 - NI LabVIEW with command-line interface support (g-cli) for LabVIEW-based actions
 - Supported platforms: Windows for LabVIEW tasks; PowerShell-only scripts also run on macOS and Linux
 
+See [Environment Setup](docs/environment-setup.md) for installation steps and commands to verify each dependency.
+
 ## GitHub Action usage
 
 ```yaml
@@ -111,6 +113,12 @@ Alternatively, load arguments from a JSON file:
 pwsh ./actions/Invoke-OSAction.ps1 -ActionName run-unit-tests -ArgsFile ./config/run-tests.json
 ```
 
+By default the dispatcher ignores unknown parameters and emits a warning. Add `-FailOnUnknown` to treat unexpected parameters as errors:
+
+```powershell
+pwsh ./actions/Invoke-OSAction.ps1 -ActionName run-unit-tests -ArgsJson $json -FailOnUnknown
+```
+
 ### Discovering actions
 
 List all available actions:
@@ -125,6 +133,10 @@ Get details about a specific action:
 pwsh actions/Invoke-OSAction.ps1 -Describe run-unit-tests
 ```
 
+## Runner Types
+
+Workflows distinguish between standard GitHub-hosted images and integration runners with preinstalled tooling. See [docs/runner-types.md](docs/runner-types.md) for a detailed comparison.
+
 ## Testing
 
 Run the JavaScript tests with:

actions/Invoke-OSAction.ps1

@@ -8,6 +8,7 @@ param(
   [Parameter()] [ValidateSet('ERROR','WARN','INFO','DEBUG')] [string] $LogLevel = 'INFO',
   [switch] $DryRun,
   [switch] $ListActions,
+  [switch] $FailOnUnknown,
   [string] $Describe
 )
 
@@ -97,8 +98,15 @@ function Show-Description([string]$Name) {
 # InputArgs: Hashtable of supplied arguments.
 # FuncName: Target dispatcher function name.
 # ActionNameForWarn: Action name used when emitting warnings.
-# ReturnUnknownParams: If set, returns unknown parameters as well.
-function Filter-Args([hashtable]$InputArgs, [string]$FuncName, [string]$ActionNameForWarn, [switch]$ReturnUnknownParams) {
+# ReturnUnknownParams: If set, returns unknown parameters and suppresses warnings.
+# NoWarn: Suppresses warnings for unknown parameters without returning them.
+function Filter-Args(
+  [hashtable]$InputArgs,
+  [string]$FuncName,
+  [string]$ActionNameForWarn,
+  [switch]$ReturnUnknownParams,
+  [switch]$NoWarn
+) {
   $cmd = Get-Command $FuncName -ErrorAction Stop
 
   # Map each alias to its canonical parameter name for the target function
@@ -124,14 +132,35 @@ function Filter-Args([hashtable]$InputArgs, [string]$FuncName, [string]$ActionNa
   $msg = $null
   if ($unknown.Count) {
     $msg = "Ignored unknown parameters for '$ActionNameForWarn': $($unknown -join ', ')"
-    Write-Warning $msg
+    if (-not $NoWarn -and -not $ReturnUnknownParams) {
+      Write-Warning $msg
+    }
   }
   if ($ReturnUnknownParams) {
     return [pscustomobject]@{ Args = $filtered; UnknownParams = $msg }
   }
   return $filtered
 }
 
+# Normalizes a RelativePath value against an optional base directory.
+# RelativePath: Path to normalize.
+# BaseDirectory: Directory used to resolve the relative path. Defaults to the current location.
+function Normalize-RelativePath {
+  param(
+    [Parameter(Mandatory)] [string] $RelativePath,
+    [string] $BaseDirectory
+  )
+  $base = if ($BaseDirectory) {
+    [System.IO.Path]::GetFullPath($BaseDirectory)
+  } else {
+    [System.IO.Directory]::GetCurrentDirectory()
+  }
+  $combined = [System.IO.Path]::Combine($base, $RelativePath)
+  $full = [System.IO.Path]::GetFullPath($combined)
+  $relative = [System.IO.Path]::GetRelativePath($base, $full)
+  return [System.IO.Path]::TrimEndingDirectorySeparator($relative)
+}
+
 try {
   # Discovery short-circuits
   if ($ListActions) { Show-List; exit 0 }
@@ -198,7 +227,19 @@ try {
   Set-LogLevel -Level $LogLevel
 
   # Only pass parameters that the adapter actually accepts
-  $argsHash = Filter-Args -InputArgs $argsHash -FuncName $funcName -ActionNameForWarn $key
+  $filterResult = Filter-Args -InputArgs $argsHash -FuncName $funcName -ActionNameForWarn $key -ReturnUnknownParams
+  $argsHash = $filterResult.Args
+  if ($filterResult.UnknownParams) {
+    if ($FailOnUnknown) {
+      throw $filterResult.UnknownParams
+    } else {
+      Write-Warning $filterResult.UnknownParams
+    }
+  }
+
+  if ($argsHash.ContainsKey('RelativePath')) {
+    $argsHash['RelativePath'] = Normalize-RelativePath -RelativePath $argsHash['RelativePath'] -BaseDirectory $WorkingDirectory
+  }
 
   if ($WorkingDirectory) { Push-Location -Path $WorkingDirectory }
   try {