Open
Conversation
d-lan1
force-pushed
the
MAS-129-DailyEmailFilds
branch
from
9cb6d58 to
94e9a23
Compare
d-lan1
force-pushed
the
MAS-129-DailyEmailFilds
branch
from
94e9a23 to
6adbe19
Compare
suegarner
suggested changes
Jan 6, 2020
| } | ||
| }; | ||
|
|
||
| var expectedHtml = "<div class='evidenceType'><strong>Some evidence type</strong><div class='item'>Some Title<br>Some source<br>Some speciality<br>Some short summary<br><a href='https://www.medicinesresources.nhs.uk/abc'>SPS Comment</a></div></div>"; |
Contributor
There was a problem hiding this comment.
Should use the extension method ShouldMatchApproved
| @@ -67,7 +67,7 @@ private string CreateContentBody(Item item) | |||
| contentBody.Append(Environment.NewLine); | |||
|
|
|||
| contentBody.Append("UKMI Comment: "); | |||
| } | ||
|
|
||
|
|
||
| public string HTML |
Contributor
There was a problem hiding this comment.
Not sure why this is a model
Author
There was a problem hiding this comment.
It makes sense to me to have a daily email model. I agree with you that HTML property may not belong in this class - but im unsure as I've seen business logic in models before and the HTML is after all just a string property returning a string interpretation of the rest of the class. The HTML properties logic could be moved into a separate service which perhaps returns a dynamic view. However, for this card I think what we currently have is ok. Perhaps in the branding card, we can look at this. What do you think?
d-lan1
commented
Jan 6, 2020
# Conflicts: # cms/models/Item.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://nicedigital.atlassian.net/browse/MAS-129