Draft
Conversation
Co-authored-by: beccadawson <beccadawson@users.noreply.github.com> Co-authored-by: John Davey <johndavey72@users.noreply.github.com>
…and add request url to file for ease of updating
…erence request URL
…into relevant test files to avoid invalid JSON errors
…ocument queries used
… reflect updated shape of mock data
…correct changes to remove data object from response shape, update note for how to generate mock data
… update (except StoryblokImage where comment is added to explain need for real path)
https://nicedigital.atlassian.net/browse/NXT-601 * NXT-601 Add new v2 ocelot endpoint to config and update calls * NXT-601 update default.yaml to use new v2 endpoint
…pgrade-to-v-2-of-storyblok-api-update-mocks
…toryblok-api-update-mocks
…toryblok-api-update-mocks
… over ocelotEndpoitnV2
… operation using x and y coordinates
Co-authored-by: Shilpa Unni <shilpanice@users.noreply.github.com> Co-authored-by: beccadawson <beccadawson@users.noreply.github.com>
…tore cv value in memory, check against it before making further calls to SB API, and improve some logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This spike explores caching the Storyblok cv (cache version) value locally in memory to avoid unnecessary calls to the spaces/me endpoint on every request, improving efficiency and enabling Ocelot to cache responses consistently (avoiding redirects caused by stale cv)
Work so far: