Skip to content

Ensure hash is always set after threads. #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niklasf merged 3 commits into from
Jan 3, 2026
Merged

Ensure hash is always set after threads. #1178

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d59bad5
Ensure hash is always set after threads.
johndoknjas Jan 2, 2026
a5bbe3e
Remove optional parameter.
johndoknjas Jan 3, 2026
a28315b
Comment Hash after Threads
niklasf Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions chess/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1875,12 +1875,16 @@ def _parse_uci_bestmove(board: chess.Board, args: str) -> BestMove:
return BestMove(move, ponder)


def _chain_config(a: ConfigMapping, b: ConfigMapping) -> Iterator[Tuple[str, ConfigValue]]:
for name, value in a.items():
yield name, value
for name, value in b.items():
if name not in a:
yield name, value
def _chain_config(a: ConfigMapping, b: ConfigMapping) -> Iterable[Tuple[str, ConfigValue]]:
merged = dict(a)
for k, v in b.items():
merged.setdefault(k, v)
if "Hash" in merged and "Threads" in merged:
# Move Hash after Threads, as recommended by Stockfish.
hash_val = merged["Hash"]
del merged["Hash"]
merged["Hash"] = hash_val
return merged.items()


class UciOptionMap(MutableMapping[str, T]):
Expand Down