-
Notifications
You must be signed in to change notification settings - Fork 0
Home
Glenice Tan edited this page Oct 7, 2018
·
4 revisions
- Install Pipenv, Docker, and docker-compose
- Clone repository and enter folder
- Run
pipenv installandpipenv shellto enter virtual environment.Ctrl-dto exit environment. - If volumes folder exists in the director,
rm -r volumes/to remove previous db records. - Run
docker-compose build - Run
docker-compose upto launch flask server and postgres server. - Navigate to
127.0.0.1in your browser to check if flask is active.
The following standards and guidelines are to be abided to closely when contributing to this project. All code is will be subjected to code review process before it is merged into master.
- Coding Standard - Google Python Style
- Commit Messages - The Art of The Commit
- Go to Issues and pick something to work on. Make sure you assign yourself the issue and select the correct project and milestone.
- If the issue does not exist, create one. Make sure to scope your issues properly, think in terms of features. For example "Implement Database System" is to broad, go with something like "Implement query feature in Webview".
- Create a branch for each new feature you implement. For simplicity's sake, only work on your own branches.
- When a feature is complete, do a pull request to master. Make sure you pass all unit tests (run
tox) before doing your pull request. Your pull request description should clearly indicate which issue the pull request is part of e.g. "part of issue #1 and issue #5". -
@niktayshall be the main code reviewer, in the event that he is unavailable@blackroxswill do code reviews. - If changes are requested, make the changes and comment "Changes made." on the pull request once you are done.
- Once your code is approved, select "Squash and Merge". Remove unnecessary commit messages e.g. "Fix typos" and leave only concrete stuff e.g. "Add database configuration", "Implement deletion from database".
- If an issue has been completely resolved, close the issue if you were the one that created it.