Fix #1471. Fix FFT calibration for odd dimensions. Test. #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmeyer
force-pushed
the
fix-1471-odd-fft-calibration
branch
from
3e7a1ad to
1cf0fad
Compare
cmeyer
force-pushed
the
fix-1471-odd-fft-calibration
branch
from
1cf0fad to
a9c01f0
Compare
Contributor
|
After reviewing this I spotted nion-software/nionswift#1600, it could be related, but since I see it on both odd and even dimensions, I have assumed it is separate and added it as a new issue. |
Collaborator
Author
|
I'm planning on holding off merging this until we re-open the projects for patches, which are on hold in order to reach a stable version. So we have time to review/fix related issues. I'd also like to put nion-software/nionswift#1596 into the fray. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70.
Please review this carefully. The tests describe the calibration assumptions for the zero frequency position: 0.5 into the "center" pixel.
NOTE: this is easiest to test if you apply nion-software/nionswift#1597 (fix drawing of spot graphics) if it hasn't already been merged.