[DRAFT] Feature: Move to Typescript Action#4
Draft
Christopher (itschip) wants to merge 14 commits intonitrado:v1from
Draft
[DRAFT] Feature: Move to Typescript Action#4Christopher (itschip) wants to merge 14 commits intonitrado:v1from
Christopher (itschip) wants to merge 14 commits intonitrado:v1from
Conversation
Author
|
This will all be rebased once ready ^ |
Author
|
And to clarify, yes, Github Actions requires the actual |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This (currently draft) PR moves it from a workflow only, to a typescript action, allowing it to be referenced and versioned easier.
Today, we do:
nitrado/hytale-plugin-workflows/.github/workflows/plugin-ci.yml@mainwhich can come off as a litte sketchy to some and you lose version control.With an actual action, we just do:
nitrado/hytale-plugin-workflows@v1.2.3It will still work the same way, but hopefully more manageable.
Also, should it be optional to create a Github release? If yes, do we output the changelog?
Things that are missing:
We can probably add more if we need that, like r2/s3.