Skip to content

Comments

[DRAFT] Feature: Move to Typescript Action#4

Draft
Christopher (itschip) wants to merge 14 commits intonitrado:v1from
itschip:feat/ts-action
Draft

[DRAFT] Feature: Move to Typescript Action#4
Christopher (itschip) wants to merge 14 commits intonitrado:v1from
itschip:feat/ts-action

Conversation

@itschip
Copy link

This (currently draft) PR moves it from a workflow only, to a typescript action, allowing it to be referenced and versioned easier.

Today, we do: nitrado/hytale-plugin-workflows/.github/workflows/plugin-ci.yml@main⁩ which can come off as a litte sketchy to some and you lose version control.
With an actual action, we just do: nitrado/hytale-plugin-workflows@v1.2.3

It will still work the same way, but hopefully more manageable.

Also, should it be optional to create a Github release? If yes, do we output the changelog?

Things that are missing:

  1. Curseforge upload
  2. Modtale upload
  3. Maven upload
  4. GCS upload

We can probably add more if we need that, like r2/s3.

@itschip
Copy link
Author

This will all be rebased once ready ^

@itschip
Copy link
Author

And to clarify, yes, Github Actions requires the actual dist, which is why it's pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant