feat(cloudrun): implement service-to-service invocation and access#11
Closed
HomelessDinosaur wants to merge 1 commit intonitrictech:mainfrom
Closed
feat(cloudrun): implement service-to-service invocation and access#11HomelessDinosaur wants to merge 1 commit intonitrictech:mainfrom
HomelessDinosaur wants to merge 1 commit intonitrictech:mainfrom
Conversation
| id = google_cloud_run_v2_service.service.name | ||
| domain_name = google_cloud_run_v2_service.service.uri | ||
| id = google_cloud_run_v2_service.service.name | ||
| domain_name = google_cloud_run_v2_service.service.uri |
Member
There was a problem hiding this comment.
should we be stripping the protocol here?
sean-nitric
reviewed
Nov 11, 2025
| # Grant service-to-service invoker permissions | ||
| # Each service that needs to invoke this service gets the run.invoker role | ||
| resource "google_cloud_run_service_iam_member" "service_invokers" { | ||
| for_each = var.suga.services |
There was a problem hiding this comment.
Are we just naïvely doing all services can intercommunicate or only the ones that have explicitly requested it?
Member
There was a problem hiding this comment.
I think the latter for security reasons. Then add a way to toggle this in the UI/yaml
Member
Author
|
Closing as not planned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.