Skip to content

fix(cli): add default outputs #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tjholm wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(cli): add default outputs #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions engines/terraform/outputs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
package terraform

import (
"github.com/aws/jsii-runtime-go"
"github.com/hashicorp/terraform-cdk-go/cdktf"
)

func (td *TerraformDeployment) createOutputs() {
for name, module := range td.terraformResources {
td.createOutputsForModule(name, module)
}

for name, module := range td.terraformInfraResources {
td.createOutputsForModule(name, module)
}
}

func (td *TerraformDeployment) createOutputsForModule(name string, module cdktf.TerraformHclModule) {
cdktf.NewTerraformOutput(td.stack, jsii.Sprintf("%s_outputs", name), &cdktf.TerraformOutputConfig{
Copy link
Member Author

@tjholm tjholm Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently outputs are scoped to <resource_name>_outputs, but this can possibly just be resource_name?

Copy link
Member

@davemooreuws davemooreuws Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the _outputs is redundant and most modules and examples don't use it.

Value: module,
})
}
3 changes: 3 additions & 0 deletions engines/terraform/terraform.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,9 @@ func (e *TerraformEngine) Apply(appSpec *app_spec_schema.Application) (result st
}
}

// Create outputs for all resources
tfDeployment.createOutputs()

tfDeployment.Synth()

return filepath.Join(e.outputDir, "stacks", appSpec.Name), nil
Expand Down