Skip to content

fix(cli): provide instructions on how to create a team#145

Merged
jyecusch merged 1 commit intomainfrom
fix/create-team-instructions
Nov 12, 2025
Merged

fix(cli): provide instructions on how to create a team#145
jyecusch merged 1 commit intomainfrom
fix/create-team-instructions

Conversation

@jyecusch
Copy link
Member

Fixes NIT-445

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 10, 2025

📝 Walkthrough

Walkthrough

The TeamApp struct gained a new exported field config *config.Config. NewTeamApp now obtains a *config.Config via do.MustInvoke and stores it on the TeamApp instance. The config package import was added. In SwitchTeam, the no-teams path now uses t.config.Url (falling back to a labeled default when empty) and prints a styled, link-guided message.

Suggested reviewers

  • tjholm
  • HomelessDinosaur

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding instructions for users on how to create a team when none exist, which aligns with the changeset that adds a user-visible message in the SwitchTeam function.
Description check ✅ Passed The description references a ticket (NIT-445) that the PR fixes, demonstrating relevance to the changeset despite minimal detail provided.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 82f9926 and ea8b115.

📒 Files selected for processing (1)
  • cli/pkg/app/team.go (5 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • cli/pkg/app/team.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Build (windows-latest, amd64)
  • GitHub Check: Security Scan
  • GitHub Check: Test

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between adb9021 and 96b6a70.

📒 Files selected for processing (1)
  • cli/pkg/app/team.go (5 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
cli/pkg/app/team.go (3)
cli/internal/config/config.go (1)
  • Config (16-20)
cli/internal/style/style.go (1)
  • Teal (16-16)
cli/internal/style/colors/colors.go (1)
  • Teal (19-19)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Security Scan
🔇 Additional comments (1)
cli/pkg/app/team.go (1)

11-11: LGTM - Clean config integration.

The config dependency is properly integrated using the existing DI pattern with MustInvoke, consistent with how auth is handled.

Also applies to: 23-23, 32-32, 44-44

@jyecusch jyecusch force-pushed the fix/create-team-instructions branch from 96b6a70 to 186f42a Compare November 10, 2025 05:23
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 96b6a70 and 186f42a.

📒 Files selected for processing (1)
  • cli/pkg/app/team.go (5 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
cli/pkg/app/team.go (3)
cli/internal/config/config.go (1)
  • Config (16-20)
cli/internal/style/style.go (1)
  • Teal (16-16)
cli/internal/style/colors/colors.go (1)
  • Teal (19-19)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Build (windows-latest, amd64)
  • GitHub Check: Security Scan
  • GitHub Check: Test
🔇 Additional comments (3)
cli/pkg/app/team.go (3)

11-11: LGTM!

Import added correctly to support config integration.


23-23: LGTM!

Config field correctly added to struct as unexported field.


32-32: LGTM!

Config correctly retrieved from injector and wired into TeamApp. Standard dependency injection pattern.

Also applies to: 44-44

@jyecusch jyecusch force-pushed the fix/create-team-instructions branch from 186f42a to 82f9926 Compare November 10, 2025 05:28
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 186f42a and 82f9926.

📒 Files selected for processing (1)
  • cli/pkg/app/team.go (5 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
cli/pkg/app/team.go (3)
cli/internal/config/config.go (1)
  • Config (16-20)
cli/internal/style/style.go (1)
  • Teal (16-16)
cli/internal/style/colors/colors.go (1)
  • Teal (19-19)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Build (windows-latest, amd64)
  • GitHub Check: Test
  • GitHub Check: Security Scan

@jyecusch jyecusch force-pushed the fix/create-team-instructions branch from 82f9926 to ea8b115 Compare November 11, 2025 02:07
@jyecusch jyecusch merged commit 95aa9a1 into main Nov 12, 2025
12 checks passed
@jyecusch jyecusch deleted the fix/create-team-instructions branch November 12, 2025 03:16
@nitric-bot
Copy link

🎉 This PR is included in version 0.6.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants