Create a package for "Klarna Checkout API - clientside events"#103
Draft
adamsoderstrom wants to merge 2 commits intomainfrom
Draft
Create a package for "Klarna Checkout API - clientside events"#103adamsoderstrom wants to merge 2 commits intomainfrom
adamsoderstrom wants to merge 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adamsoderstrom
commented
May 3, 2023
Comment on lines
+17
to
+27
| ## Usage | ||
|
|
||
| ```typescript | ||
| import type { Klarna } from '@noaignite/klarna-checkout-types' | ||
|
|
||
| declare global { | ||
| interface Window { | ||
| _klarnaCheckout?: (callback: Klarna.CheckoutCallback) => void | ||
| } | ||
| } | ||
| ``` |
Member
Author
There was a problem hiding this comment.
I wonder if this should be done inside the actual package..? 🤔
Member
Author
|
Would be great if i could get some assistance on publishing + review! 💞 |
Contributor
|
question: Is this still relevant? If so, I guess we'd want to rebase against the new Going through PRs now that we're up and running again with our internal packages. |
adamsoderstrom
commented
Aug 15, 2024
| @@ -0,0 +1,28 @@ | |||
| # @noaignite/centra-types | |||
Member
Author
There was a problem hiding this comment.
todo: change to @noaignite/klarna-checkout-types
adamsoderstrom
commented
Aug 15, 2024
Member
Author
There was a problem hiding this comment.
note: This package should not be used in Centra projects. Add that to the README.md
Member
Author
|
todo: Verify that these types are up-do-date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In attempt to have complete TS coverage in a project, you'd need to type external dependencies.
This PR covers one of these scenarios.
This PR provides a package, containing the type definition of the
window._klarnaCheckoutfunction.The PR is interpreted from the documentation of the Klarna Checkout > In-depth Knowledge > Client-side events.
By consuming this package, you be able to get type definitions on the callbacks from your
_klarnaCheckoutfunction:Before
After