Use --target instead of building with each node version

[zbjornson]

I have not tested this, but this should avoid the issue with Appveyor being slow to update their images and speed up the builds.

I don't know what $NODEJS_VERSIONS looks like; the --target option takes a full vX.Y.Z string, not just X. If you're only using X you could change it to --target=v$ver.0.0.

[chearon]

I know I tried this before and I didn't like the fact that node-gyp --target requires a full version string (edit: ah you said that in the description!). So we have to specify builds as 12.x.x 11.x.x 10.x.x in the environment variables instead of 12 11 10.

It'll be another burden but probably worth it.

Hopefully there weren't any other issues I'm not recalling. After the comment is addressed I'll give it a test run.

[chearon]

This looks like it was moved from the old node_version.sh file, could you do the nvm commands in ci/linux|osx/preinstall.sh? At that point NVM is already setup.

I think you would just add

nvm install node # latest
nvm use node # latest
npm install -g node-gyp 

Could do Windows node installation in win/preinstall.sh for consistency, or leave it in appveyor.yml since it was already there.

[chearon]

1. I was wrong about ci/*/preinstall.sh being ready for NVM, that was true for Linux but not macOS, I've made the fix to .travis.yml for the latter.
2. I just remembered the reason why I didn't do this. In order to test if the build worked we need node.

node-canvas-prebuilt/ci/install.sh

Lines 50 to 53 in b5aea29

	node -e "require('./node-canvas')" || {
	echo "error loading binary";
	exit 1;
	}

So we probably do need ci/*/node_version.sh so it can use Install-Product or whatever it does in master, and it can now just do a simple nvm install/nvm use in macOS and Linux. Then I guess we'll have to add something that skips the testing if a node version isn't available 😕 I'm not sure what else we can do unless there's some alternate to NVM for Windows.

[zbjornson]

Ahh. What about downloading the portable node executables from https://nodejs.org/dist/vX.Y.Z for testing?

e.g.

https://nodejs.org/dist/v10.16.0/win-x64/node.exe

[chearon]

That should work yeah, ci/win/node_version.sh can use wget, then probably has to do alias node ='./vX.Y.Z.exe' (hopefully that doesn't have side effects 😬). Note that I changed your example wiki code a bit, the version variable doesn't have the v in it.

I still like using node-gyp's version argument though, we can leave that.

[fpauser]

Any news on this?

[zbjornson]

Moot since Automattic/node-canvas#1568