Open
Conversation
targos
reviewed
Jan 30, 2022
targos
approved these changes
Jan 30, 2022
benjamingr
reviewed
Jan 30, 2022
alexeagle
reviewed
Jan 30, 2022
alexeagle
reviewed
Jan 30, 2022
toolchain-analysis/bazel.md
Outdated
| ## Cons | ||
|
|
||
| * Other dependencies will need Node.js-maintained Bazel build files | ||
| * Currently support a limited set of platforms |
There was a problem hiding this comment.
I'm curious which host platforms node supports and Bazel doesn't? Perhaps the Bazel team can ship more binaries.
Contributor
Author
There was a problem hiding this comment.
It's less about bazel running on the platform and more about V8 providing the configurations for those platforms or not (according to this comment the range of platforms supported by the bazel configs is only a subset of currently supported platforms with GN).
|
|
||
| ## Need more info | ||
|
|
||
| * Could V8 use Bazel instead of GN in their CI? |
There was a problem hiding this comment.
I think @philwo is best suited to answer this.
mmarchini
force-pushed
the
bazel-toolchain-analysis
branch
from
6b5def1 to
6b6db21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this only refers to building Node.js itself, not addons. An analysis of options for addons might be done in the future
This analysis is based on information gathered on
nodejs/TSC#901. We still need to collect more
information, especially in currently supported platforms and toolchains
(including minimum version for both). Consolidating the information here so
it's easier for us to iterate on it.