Open
Conversation
targos
approved these changes
Jan 30, 2022
Co-authored-by: Michaël Zasso <targos@protonmail.com>
mhdawson
reviewed
Feb 1, 2022
Co-authored-by: Michael Dawson <mdawson@devrus.com>
vweevers
reviewed
Feb 2, 2022
|
|
||
| * There seems to be positive reception at the idea of cmake for native modules, | ||
| having the same build system for building Node.js and its native modules | ||
| * It is already possible to build node-addon-api based native modules with cmake. |
There was a problem hiding this comment.
This is true for every build toolchain and also API (not just node-addon-api) so how valuable is this observation as a comparison to other toolchains?
Member
There was a problem hiding this comment.
It is one that I know people have already been using and has been tested out/validated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this only refers to building Node.js itself, not addons. An analysis of options for addons might be done in the future
This analysis is based on information gathered on
nodejs/TSC#901. We still need to collect more
information, especially in currently supported platforms and toolchains
(including minimum version for both). Consolidating the information here so
it's easier for us to iterate on it.