WIP promote: update tests for check_assets.js#3968
Closed
richardlau wants to merge 3 commits intonodejs:mainfrom
Closed
WIP promote: update tests for check_assets.js#3968richardlau wants to merge 3 commits intonodejs:mainfrom
richardlau wants to merge 3 commits intonodejs:mainfrom
Conversation
Tests needed to be updated after `docs/apilinks.json` was added to the expected assets for `v10.x`. Refs: nodejs#2278
Member
Author
|
Superseded by #3971. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit fixes the tests that were inadvertently broken when #2278 landed.
Second WIP commit is converting to
node:test.Refs: #3958