doc: buffer allocation methods throw for negative size

[joyeecheung]

Checklist

• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

doc

Description of change

Update the doc to match the current behavior.

Ref: #7079

[sam-github]

if size is 0

Use English words consistently, as in the previous sentence.

[joyeecheung]

Thanks for pointing this out. Addressed.

[sam-github]

is 0

[joyeecheung]

Fixed. Sorry for pushing too fast before the review complete.

[sam-github]

Why did you say issue is addressed? Did you forget to push? There are still 5 instances of === used in the doc text.

[addaleax]

@sam-github Why did you tag this semver-major? This matches current behaviour on v7.x.

[joyeecheung]

Why did you say issue is addressed? Did you forget to push? There are still 5 instances of === used in the doc text.

Sorry, I pushed before the review was finished, so it's partially addressed.

[sam-github]

@addaleax sorry, I thought this was changing the Buffer to throw

[joyeecheung]

Ping. Is there anything stopping this from being landed?

[cjihrig]

It needs a CI run. So, https://ci.nodejs.org/job/node-test-pull-request/5341/

[addaleax]

@cjihrig It’s a docs change :)

I think the only thing this has been waiting for were the mandatory 48 hours before landing but we might as well wait for CI to finish now that it’s started

[cjihrig]

@addaleax D'oh. I looked that it had been reviewed and saw there was no CI run, but didn't look at anything else. 😔

[addaleax]

Landed in bc335c0 (had to trim the commit subject line a bit to fit it into 50 characters)

Thanks for the ping!

[joyeecheung]

I think the only thing this has been waiting for were the mandatory 48 hours before landing but we might as well wait for CI to finish now that it’s started

Hmm.. I had no idea that there is a mandatory 48 hours wait. Did a little bit of searching and turns out it is described in the onboarding guide, but I think the contributing guide should mention this as well?