stream: always emit error before close#19836
Closed
mafintosh wants to merge 2 commits intonodejs:masterfrom
Closed
stream: always emit error before close#19836mafintosh wants to merge 2 commits intonodejs:masterfrom
mafintosh wants to merge 2 commits intonodejs:masterfrom
Conversation
4 tasks
mcollina
reviewed
Apr 5, 2018
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
Can you add a test just for destroy()?
mafintosh
force-pushed
the
fix-stream-destroy-events-order
branch
2 times, most recently
from
102b6fe to
2f59bb3
Compare
Member
Author
|
@mcollina added test, PTAL |
BridgeAR
approved these changes
Apr 5, 2018
lpinca
approved these changes
Apr 5, 2018
Member
Contributor
|
I think you may need to rebase to include the recent npm version reverts to fix the CI failures? |
Member
|
Rebuilding CI: https://ci.nodejs.org/job/node-test-pull-request/14080/ This should rebase automatically … let’s see what happens |
BridgeAR
added
the
author ready
mafintosh
force-pushed
the
fix-stream-destroy-events-order
branch
from
2f59bb3 to
dfd2f30
Compare
Member
Author
|
Rebased... |
Member
Author
Member
Author
|
Landed in a7c25b7 |
mafintosh
added a commit
that referenced
this pull request
Apr 9, 2018
PR-URL: #19836 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesExtracted from #19828. Fixes an issue from my error-handling pr, #18438 where a stream emits
closebeforeerroron destroy. It should beerrorbeforeclose.