Skip to content

Comments

fs: add throwIfNoEntry option for fs.stat and fs.promises.stat#61178

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
juanarbol:juan/fs-throwifnoentry
Feb 11, 2026
Merged

fs: add throwIfNoEntry option for fs.stat and fs.promises.stat#61178
nodejs-github-bot merged 1 commit intonodejs:mainfrom
juanarbol:juan/fs-throwifnoentry

Conversation

@juanarbol
Copy link
Member

@juanarbol juanarbol commented Dec 26, 2025

Fixes: #61116

@juanarbol
fs: add throwIfNoEntry option for fs.stat and fs.promises.stat
6989430 
Fixes: nodejs#61116
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Dec 26, 2025
@codecov
Copy link

codecov bot commented Dec 27, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 81.25000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.53%. Comparing base (5e677d6) to head (6989430).
⚠️ Report is 344 commits behind head on main.

Files with missing lines Patch % Lines
src/node_file.cc 73.91% 3 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61178      +/-   ##
==========================================
+ Coverage   88.52%   88.53%   +0.01%     
==========================================
  Files         703      703              
  Lines      208585   208610      +25     
  Branches    40225    40235      +10     
==========================================
+ Hits       184650   184702      +52     
+ Misses      15953    15911      -42     
- Partials     7982     7997      +15
Files with missing lines Coverage Δ
lib/fs.js 98.18% <100.00%> (+<0.01%) ⬆️
lib/internal/fs/promises.js 98.15% <100.00%> (+<0.01%) ⬆️
src/node_file.cc 75.47% <73.91%> (-0.05%) ⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

avivkeller
avivkeller reviewed Dec 28, 2025
View reviewed changes
juanarbol
juanarbol commented Dec 28, 2025
View reviewed changes
@juanarbol juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 2, 2026
@juanarbol
Copy link
Member Author

juanarbol commented Feb 2, 2026

@jasnell PTAL

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 2, 2026
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 2, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71171/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 3, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71176/

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 5, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71209/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 10, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71294/

@juanarbol juanarbol added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 10, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 11, 2026
@nodejs-github-bot nodejs-github-bot merged commit 31bf4fb into nodejs:main Feb 11, 2026
83 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 11, 2026

Landed in 31bf4fb

aduh95 pushed a commit that referenced this pull request Feb 19, 2026
@juanarbol @aduh95
fs: add throwIfNoEntry option for fs.stat and fs.promises.stat
4cecbe1 
Fixes: #61116
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #61178
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avivkeller avivkeller avivkeller left review comments

@anonrig anonrig anonrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fs.promises.stat: Missing option throwIfNoEntry

4 participants

@juanarbol @nodejs-github-bot @anonrig @avivkeller